refactor: move into npm workspace #1304
Conversation
✅ Deploy Preview for netlify-plugin-nextjs-demo canceled.
|
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ascorbic
force-pushed
the
mk/workspace
branch
2 times, most recently
from
a1bc47a to
eee8c37
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| @@ -0,0 +1 @@ | |||
| 17.9.0 | |||
There was a problem hiding this comment.
Should this perhaps be set to v16 so that this is on an LTS version of node? Or is there something about v17 that we want for these changes?
Depending on when it's looking like these changes will be merged and released we might be able to even go up to the newest LTS version (v18) which will be released on the April 19th.
There was a problem hiding this comment.
Yeah, I did this because I thought it needed to be 17 for workspaces to work properly, but I think 16 should be ok. Good point re 18 though. We should probably migrate later.
I still need to work out the best way to run the node 12 tests though, because right now they're failing as they don't support workspaces at all.
ascorbic
force-pushed
the
mk/workspace
branch
3 times, most recently
from
4e88f7a to
2a7d5d1
Compare
ascorbic
force-pushed
the
mk/workspace
branch
6 times, most recently
from
43bdd60 to
1863b7e
Compare
ascorbic
added
the
type: chore
| @@ -23,13 +23,20 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: Use Node.js ${{ matrix.node-version }} | |||
| - name: Installing with latest Node.js | |||
There was a problem hiding this comment.
This is so we can use workspaces, which require node 16, but still run tests in node 12
| "test": "run-s build build:demo test:jest", | ||
| "build": "npm run -w @netlify/plugin-nextjs build", | ||
| "postinstall": "run-s build install-husky", | ||
| "install-husky": "if-env CI=1 || husky install node_modules/@netlify/eslint-config-node/.husky", |
There was a problem hiding this comment.
It was causing issues installing this in CI
|
Yeah, hopefully that means Next will drop support soon! Right now we're matching the minimum version supported by the latest version of each framework, so Gatsby uses 14 |
| @@ -16,25 +16,27 @@ jobs: | |||
| id: release | |||
| with: | |||
| token: ${{ steps.get-token.outputs.token }} | |||
| release-type: node | |||
| package-name: '@netlify/plugin-nextjs' | |||
| command: manifest | |||
There was a problem hiding this comment.
We're changing to manifest releases because the package is in a subdirectory
Summary
This PR moves the plugin and one demo site into an npm workspace, to make it easier to manage packages, and to better handle dependency caching.
Before it can be merged the release please scripts and config need changing to reflect the fact that the plugin isn't in the root.
Test plan
This will involve ensuring all the demo sites build properly
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.